Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Request and Response on global object #2187

Closed
jed opened this issue Apr 23, 2019 · 3 comments
Closed

Expose Request and Response on global object #2187

jed opened this issue Apr 23, 2019 · 3 comments

Comments

@jed
Copy link

jed commented Apr 23, 2019

The global object currently surfaces the following:

> this
{ Deno, denoMain, window, atob, btoa, fetch, clearTimeout, clearInterval,
setTimeout, setInterval, location, Blob, File, CustomEventInit, CustomEvent,
EventInit, Event, EventTarget, URL, URLSearchParams, Headers, FormData,
TextEncoder, TextDecoder, performance, onmessage, workerMain,
workerClose, postMessage, Worker }

Since fetch uses the Request and Response interfaces, and those interfaces are often used along with fetch, those too should be surfaced (they are in Chrome, for example). The absence of these interfaces causes aws4fetch to fail with an Uncaught ReferenceError: Request is not defined error.

@ry
Copy link
Member

ry commented Apr 23, 2019

👋

Yes we should expose it. This is a duplicate of #2108. Closing this one.

@ry ry closed this as completed Apr 23, 2019
@jed
Copy link
Author

jed commented Apr 23, 2019

Ah, thanks! And for changing the issue name to make it easier to find...

@jed
Copy link
Author

jed commented Apr 23, 2019

(Interacting with @ry on GitHub about an exciting new project feels very 2009 and I like it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants