deno upgrade permission check should check cliOptionOutput

[loynoir]

Actual

$ deno upgrade --version 1.30.3 --output ./deno_1_30_3
error: You don't have write permission to /usr/bin/deno because it's owned by root.
Consider updating deno through your package manager if its installed from it.
Otherwise run `deno upgrade` as root.

Workaround

$ sudo deno upgrade --version 1.30.3 --output ./deno_1_30_3
Downloading https://github.com/denoland/deno/releases/download/v1.30.3/deno-x86_64-unknown-linux-gnu.zip
...

Expected

deno upgrade should permission check ./deno_1_30_3 instead of /usr/bin/deno

Related

#18405
#18406
#18438
#18440

[dsherret]

Thanks! The incorrect code is here:

deno/cli/tools/upgrade.rs

Lines 267 to 286 in d740a9e

	let current_exe_path = std::env::current_exe()?;
	let metadata = fs::metadata(&current_exe_path)?;
	let permissions = metadata.permissions();
	if permissions.readonly() {
	bail!(
	"You do not have write permission to {}",
	current_exe_path.display()
	);
	}
	#[cfg(unix)]
	if std::os::unix::fs::MetadataExt::uid(&metadata) == 0
	&& !nix::unistd::Uid::effective().is_root()
	{
	bail!(concat!(
	"You don't have write permission to {} because it's owned by root.\n",
	"Consider updating deno through your package manager if its installed from it.\n",
	"Otherwise run `deno upgrade` as root.",
	), current_exe_path.display());
	}

[dsherret]

Reopining because the fix was reverted in #18467. We need to not error when the output path doesn't exists.

[RyanClementsHax]

Is this still a good first issue? I'm looking to help out somewhere

[itsajay1029]

Can I work on this @dsherret ? Pls assign it to me

[dsherret]

Thanks, but I think there is already an open PR #18994