[BUG] lsp dts importmap

[loynoir]

Brief

Within importmap context, dts should resolve to dts of target file, instead of dts of source file.

Edit: Not sure what happend, but I guess it's dts problem on lsp side.

Reproduce

import_map.json

{
  "imports": {
    "comment-json": "npm:[email protected]",
    "fs/promises": "https://deno.land/[email protected]/node/fs/promises.ts",
    "node:fs/promises": "https://deno.land/[email protected]/node/fs/promises.ts"
  }
}

Actual

Within vscode, below code type error on importId comment-json

import { parse, stringify } from 'comment-json'
console.log({ parse, stringify })
import { readFile, writeFile } from 'node:fs/promises'
console.log({ readFile, writeFile })

Resolved Dependency

Code: npm​:comment-json​@4.2.3

Uncached or missing npm package: "[email protected]".deno(no-cache-npm)

denoland.vscode-deno deno language server log have many repeated same error, @types/node not found

Could not set npm package requirements.  \
Error getting response at https://registry.npmjs.org/@types/node: \
An npm specifier not found in cache: "@types/node", --cached-only is specified.

Expected

Within vscode, below code types are OK

import { parse, stringify } from 'comment-json'
console.log({ parse, stringify })
import { readFile, writeFile } from 'node:fs/promises'
console.log({ readFile, writeFile })

Workaround

Within vscode, below code types are OK

import { parse, stringify } from 'comment-json'
console.log({ parse, stringify })
import { readFile, writeFile } from 'fs/promises'
console.log({ readFile, writeFile })

Edit

Above workaround, offen works, sometimes still got type error on comment-json

[bartlomieju]

Run Cache dependencies from the command pallete and the error should go away.

[loynoir]

@bartlomieju

• I cache them,
• and extension show warning on comment-json,
• then I check lsp log, found lsp complaning missing @types/node,

Could not set npm package requirements.  \
Error getting response at https://registry.npmjs.org/@types/node: \
An npm specifier not found in cache: "@types/node", --cached-only is specified.

• repeat cache serverl times and different timepoint, still found issue reproduceable.
• repeat restart deno server, still found issue reproduceable.
• so I create the issue.
• If I did not cache them, the workaround should never works, instead of often works.

[loynoir]

The errors are gone.