Skip to content

Commit

Permalink
Enables symbols loading with mono
Browse files Browse the repository at this point in the history
  • Loading branch information
demelev committed Feb 26, 2024
1 parent 0807f82 commit 726a344
Showing 1 changed file with 13 additions and 5 deletions.
18 changes: 13 additions & 5 deletions src/Sentry.Unity.Editor/Android/AndroidManifestConfiguration.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ public class PostGenerateGradleAndroidProject : IPostGenerateGradleAndroidProjec
public int callbackOrder { get; } = 1;
public void OnPostGenerateGradleAndroidProject(string basePath)
{
var (options, cliOptions) = SentryScriptableObject.ConfiguredBuildTimeOptions();
var androidManifestConfiguration = new AndroidManifestConfiguration();
androidManifestConfiguration.OnPostGenerateGradleAndroidProject(basePath);
androidManifestConfiguration.OnPostGenerateGradleAndroidProject(basePath, cliOptions);
}
}

Expand Down Expand Up @@ -57,8 +58,18 @@ internal AndroidManifestConfiguration(
_scriptingImplementation = scriptingImplementation;
}

public void OnPostGenerateGradleAndroidProject(string basePath)
public void OnPostGenerateGradleAndroidProject(string basePath, SentryCliOptions? cliOptions)
{

var unityProjectPath = Directory.GetParent(Application.dataPath).FullName;
var gradleProjectPath = Directory.GetParent(basePath).FullName;

if (cliOptions?.UploadSymbols is true)
{
_logger.LogWarning("Uploading android symbols!");
SetupSymbolsUpload(unityProjectPath, gradleProjectPath);
}

if (_scriptingImplementation != ScriptingImplementation.IL2CPP)
{
if (_options is { AndroidNativeSupportEnabled: true })
Expand All @@ -71,9 +82,6 @@ public void OnPostGenerateGradleAndroidProject(string basePath)

ModifyManifest(basePath);

var unityProjectPath = Directory.GetParent(Application.dataPath).FullName;
var gradleProjectPath = Directory.GetParent(basePath).FullName;

CopyAndroidSdkToGradleProject(unityProjectPath, gradleProjectPath);
AddAndroidSdkDependencies(gradleProjectPath);
SetupSymbolsUpload(unityProjectPath, gradleProjectPath);
Expand Down

0 comments on commit 726a344

Please sign in to comment.