Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzz test calculate_* trades against solidity #937

Closed
slundqui opened this issue Apr 3, 2024 · 1 comment
Closed

Fuzz test calculate_* trades against solidity #937

slundqui opened this issue Apr 3, 2024 · 1 comment

Comments

@slundqui
Copy link
Contributor

slundqui commented Apr 3, 2024

There are limited tests for rust calculate_* functions against what's implemented in solidity:

  • Open long/short doesn't fuzz against solidity.
  • Close long/short only fuzzes the underlying calculate_close_long_flat_plus_curve and calculate_close_short_flat_plus_curve against the calculate_close_* from hyperdrive math. However, these functions do not take fees or negative interest checks into account (both on the solidity and rust side).

Ideally, we would fuzz these trades against the public interface of hyperdrive.

@dpaiton
Copy link
Contributor

dpaiton commented May 1, 2024

Duplicate of delvtech/hyperdrive-rs#20; closing

@dpaiton dpaiton closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants