From 82e912220b9dd25a6a9e6bd7c64d8c0b0642e679 Mon Sep 17 00:00:00 2001 From: Matthew Brown Date: Mon, 28 Oct 2024 16:44:37 -0500 Subject: [PATCH] fix nits, add documentation --- .../aerodrome-lp/AerodromeLpHyperdriveDeployerCoordinator.sol | 4 ++-- .../src/deployers/aerodrome-lp/AerodromeLpTarget2Deployer.sol | 2 -- .../src/deployers/aerodrome-lp/AerodromeLpTarget3Deployer.sol | 2 -- .../src/deployers/aerodrome-lp/AerodromeLpTarget4Deployer.sol | 2 -- tasks/deploy/config/base/aerodrome-lp-aero-usdc-91day.ts | 4 +++- 5 files changed, 5 insertions(+), 9 deletions(-) diff --git a/contracts/src/deployers/aerodrome-lp/AerodromeLpHyperdriveDeployerCoordinator.sol b/contracts/src/deployers/aerodrome-lp/AerodromeLpHyperdriveDeployerCoordinator.sol index 787d6a09c..926b93fb4 100644 --- a/contracts/src/deployers/aerodrome-lp/AerodromeLpHyperdriveDeployerCoordinator.sol +++ b/contracts/src/deployers/aerodrome-lp/AerodromeLpHyperdriveDeployerCoordinator.sol @@ -139,7 +139,7 @@ contract AerodromeLpHyperdriveDeployerCoordinator is revert IHyperdriveDeployerCoordinator.InvalidBaseToken(); } - // Ensure that the minimum share reserves are equal to 1e7. This value + // Ensure that the minimum share reserves are equal to 1e8. This value // has been tested to prevent arithmetic overflows in the // `_updateLiquidity` function when the share reserves are as high as // 200 million. @@ -147,7 +147,7 @@ contract AerodromeLpHyperdriveDeployerCoordinator is revert IHyperdriveDeployerCoordinator.InvalidMinimumShareReserves(); } - // Ensure that the minimum transaction amount are equal to 1e7. This + // Ensure that the minimum transaction amount are equal to 1e8. This // value has been tested to prevent precision issues. if (_deployConfig.minimumTransactionAmount != 1e8) { revert IHyperdriveDeployerCoordinator diff --git a/contracts/src/deployers/aerodrome-lp/AerodromeLpTarget2Deployer.sol b/contracts/src/deployers/aerodrome-lp/AerodromeLpTarget2Deployer.sol index acc5b2d14..4b01d6fe3 100644 --- a/contracts/src/deployers/aerodrome-lp/AerodromeLpTarget2Deployer.sol +++ b/contracts/src/deployers/aerodrome-lp/AerodromeLpTarget2Deployer.sol @@ -30,8 +30,6 @@ contract AerodromeLpTarget2Deployer is IHyperdriveTargetDeployer { // deposited. require(_extraData.length >= 20, "Invalid _extraData length"); IGauge gauge = abi.decode(_extraData, (IGauge)); - // The Aerodrome Gauge contract. This is where the base token will be - // deposited. return address( diff --git a/contracts/src/deployers/aerodrome-lp/AerodromeLpTarget3Deployer.sol b/contracts/src/deployers/aerodrome-lp/AerodromeLpTarget3Deployer.sol index 4f6450142..c7c5e8f72 100644 --- a/contracts/src/deployers/aerodrome-lp/AerodromeLpTarget3Deployer.sol +++ b/contracts/src/deployers/aerodrome-lp/AerodromeLpTarget3Deployer.sol @@ -30,8 +30,6 @@ contract AerodromeLpTarget3Deployer is IHyperdriveTargetDeployer { // deposited. require(_extraData.length >= 20, "Invalid _extraData length"); IGauge gauge = abi.decode(_extraData, (IGauge)); - // The Aerodrome Gauge contract. This is where the base token will be - // deposited. return address( diff --git a/contracts/src/deployers/aerodrome-lp/AerodromeLpTarget4Deployer.sol b/contracts/src/deployers/aerodrome-lp/AerodromeLpTarget4Deployer.sol index 85d67a83e..d27788cc8 100644 --- a/contracts/src/deployers/aerodrome-lp/AerodromeLpTarget4Deployer.sol +++ b/contracts/src/deployers/aerodrome-lp/AerodromeLpTarget4Deployer.sol @@ -30,8 +30,6 @@ contract AerodromeLpTarget4Deployer is IHyperdriveTargetDeployer { // deposited. require(_extraData.length >= 20, "Invalid _extraData length"); IGauge gauge = abi.decode(_extraData, (IGauge)); - // The Aerodrome Gauge contract. This is where the base token will be - // deposited. return address( diff --git a/tasks/deploy/config/base/aerodrome-lp-aero-usdc-91day.ts b/tasks/deploy/config/base/aerodrome-lp-aero-usdc-91day.ts index 3d41a2207..b38bcd9e7 100644 --- a/tasks/deploy/config/base/aerodrome-lp-aero-usdc-91day.ts +++ b/tasks/deploy/config/base/aerodrome-lp-aero-usdc-91day.ts @@ -35,7 +35,9 @@ export const BASE_AERODROME_LP_AERO_USDC_91DAY: HyperdriveInstanceConfig<"Aerodr salt: toBytes32("0x69420"), extraData: AERO_USDC_GAUGE_ADDRESS_BASE, contribution: CONTRIBUTION, - fixedAPR: parseEther("0.08"), + // The emissions APR can be found here: + // https://aerodrome.finance/deposit?token0=0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913&token1=0x940181a94A35A4569E4529A3CDfB74e38FD98631&type=-1 + fixedAPR: parseEther("0.5468"), timestretchAPR: parseEther("0.075"), options: async (hre: HardhatRuntimeEnvironment) => ({ extraData: "0x",