Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this a drop-in replacement for https-proxy-agent? #106

Open
zkochan opened this issue Feb 17, 2023 · 3 comments
Open

Is this a drop-in replacement for https-proxy-agent? #106

zkochan opened this issue Feb 17, 2023 · 3 comments

Comments

@zkochan
Copy link

zkochan commented Feb 17, 2023

I am coming from this issue, where @dscalzi has suggested to used this package instead.

I use https-proxy-agent in pnpm and I wonder if it is safe to make the switch. I did try to switch it and everything seems to works. But I do see some difference between the two packages. Like I don't see in this package anything related to ALPNProtocols, like in https-proxy-agent:

https://github.com/TooTallNate/node-https-proxy-agent/blob/d0d80cc0482f20495aa8595f802e1a9f3b1b3409/src/agent.ts#L61-L65

Is this package a feature complete drop-in replacement to https-proxy-agent?

@trevor-rex
Copy link

Have you had success in using this package instead? It does seem slightly more up-to-date than TooTallNate's package. Do you happen to know if this is compatible with Node 16?

@zkochan
Copy link
Author

zkochan commented Apr 20, 2023

No, I have not risked to make a switch. I have used a workaround to make https-proxy-agent work: pnpm/components@02d17cc

@scarabcoder
Copy link

For future people finding this from Google, I found this to be a good replacement for https-proxy-agent. I was having issues with https-proxy-agent not passing the ca certificate to the CONNECT HTTP call in addition to the proxied request, which this library solved.
It doesn't look like this library has been updated in awhile, but it is working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants