Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rpgp version to 0.2.1 #844

Merged
merged 1 commit into from
Jun 9, 2019
Merged

Update rpgp version to 0.2.1 #844

merged 1 commit into from
Jun 9, 2019

Conversation

Jikstra
Copy link
Contributor

@Jikstra Jikstra commented Jun 7, 2019

This also needs that we update the docker travis image https://hub.docker.com/r/deltachat/travis-dc-node-base . I don't know how to push that image, but updated the Dockerfile. @flub can you help out?

@flub
Copy link
Member

flub commented Jun 9, 2019

Hmm, i'm not sure. The Dockerfile used to be in this repo in as docker/Dockerfile but it's gone? /cc @ralphtheninja

@ralphtheninja
Copy link
Member

@Jikstra
Copy link
Contributor Author

Jikstra commented Jun 9, 2019

Hmm, i'm not sure. The Dockerfile used to be in this repo in as docker/Dockerfile but it's gone? /cc @ralphtheninja

It's still there, i modified it in this PR too :D

https://github.com/deltachat/deltachat-desktop/pull/844/files#diff-ebacf6f6ae4ee68078bb16454b23247d

It's only about pushing a new image to the deltachat group/docker account that i dont know how to do it.

@flub
Copy link
Member

flub commented Jun 9, 2019

oh wait. desktop, not node. oops.

anyway, docker build -t deltachat/travis-dc-node-base:latest docker/ docker push -t docker push deltachat/travis-dc-node-base:latest should do it. You're a member of the deltachat org on docker hub so should have permissions to do so, but if you prefer i'm happy to push it too (might be faster)

@Jikstra
Copy link
Contributor Author

Jikstra commented Jun 9, 2019

but if you prefer i'm happy to push it too (might be faster)

Yup would be happy if you can do it :)

@flub flub merged commit 28f41a4 into master Jun 9, 2019
@ralphtheninja ralphtheninja deleted the fix_upgrade_rpgp branch June 9, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants