Sort chat list on update #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update chat list when chat changes
ralphtheninja
approved these changes
Jun 6, 2019
Jikstra
reviewed
Jun 6, 2019
| @@ -11,15 +11,19 @@ const chatListStore = new Store(defaultState) | |||
| // value for text1Meaning | |||
| const DC_TEXT1_DRAFT = 1 | |||
|
|
|||
| function sortChatList (first, second) { | |||
| return first.summary.timestamp > second.summary.timestamp ? -1 : 1 | |||
There was a problem hiding this comment.
I think that sorting the chatlist isn't needed, instead we should have another array which just holds the chatIds in the correct order how we get it from the core. This way we can just refetch with one call. But I will try to implement that on top of this, first lets get this bug fixed.
Jikstra
approved these changes
Jun 6, 2019
|
A general nit pick: Please try to remember to clean up branches after merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update chat list when chat changes
Resolves #831
The chat list gets updated now on every DC_EVENT_CHAT_MODIFIED event.
Maybe we should test and check for more events which might not be handled...