State refactor #583
Merged
State refactor #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphtheninja
commented
Jan 13, 2019
| } | ||
|
|
||
| function sendState (deltachat) { | ||
| Object.assign(state, { deltachat }) |
There was a problem hiding this comment.
Here we pass all state to render process and not only the deltachat data.
|
I'm still not 100% happy with the state, but I think it's a lot better than before. Also less code for the same functionality. |
ralphtheninja
force-pushed
the
state-rewrite
branch
from
1867805 to
82534ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #576