Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logger a bit #1026

Merged
merged 5 commits into from
Oct 2, 2019
Merged

Improve logger a bit #1026

merged 5 commits into from
Oct 2, 2019

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Sep 30, 2019

  • omit stacktrace for debug and info
  • move core event logs to their own log channel (makes event output smaller and less annoying)
  • change logile extention to .log.tsv
  • add colors, time elapsed and generally rework main process logging a bit:
    2019-09-30_23-17

@Simon-Laux
Copy link
Member Author

2019-09-30_23-25

src/logger.js Show resolved Hide resolved
src/logger.js Show resolved Hide resolved
Copy link
Contributor

@Jikstra Jikstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful. You said that core events are now in their own channel, how can i still see them?

@Simon-Laux
Copy link
Member Author

Very helpful. You said that core events are now in their own channel, how can i still see them?

With channel I mean channel of the logger. At the moment there is no filtering going on at all so all channels are displayed. We might develop a log reader that can filter the channels of the logfiles to make reading them easier.
At the moment the change is:
before:

main/deltachat DEBUG [] Core Event DC_EVENT_INFO  IMAP-IDLE SPAWNING

after:

core/event DEBUG [] DC_EVENT_INFO  IMAP-IDLE SPAWNING

after all changes:

3.2s [D]core/event: DC_EVENT_INFO  IMAP-IDLE SPAWNING

@Simon-Laux Simon-Laux requested a review from Jikstra October 1, 2019 13:24
@Jikstra Jikstra merged commit 3207826 into master Oct 2, 2019
@Jikstra Jikstra deleted the improve-logger branch October 2, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants