Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple constraints at once #1986

Open
ion-elgreco opened this issue Dec 20, 2023 · 11 comments
Open

Add multiple constraints at once #1986

ion-elgreco opened this issue Dec 20, 2023 · 11 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ion-elgreco
Copy link
Collaborator

Description

Currently add constraints is limited to one named expression. But we can add a hash map as well in one go.

@ion-elgreco ion-elgreco added the enhancement New feature or request label Dec 20, 2023
@ion-elgreco
Copy link
Collaborator Author

@hntd187, I created an issue to track the progress for this, feel free to assign this to yourself

@hntd187
Copy link
Collaborator

hntd187 commented Dec 20, 2023

Take

@Nordalf
Copy link
Contributor

Nordalf commented Jun 4, 2024

Ping. Is anyone working on this?

@ion-elgreco
Copy link
Collaborator Author

@Nordalf hi, as far as I know not, do you want to pick it up?

@Nordalf
Copy link
Contributor

Nordalf commented Jun 5, 2024

@ion-elgreco - maybe, if I get some time to do it.

A thought:
When adding a constraint today, each add will bump the version of the delta table (new log entry). If adding a HashMap, should it bump the version once with multiple commit infos in the same log or provide a new log entry for each key in the map?

@ion-elgreco
Copy link
Collaborator Author

@ion-elgreco - maybe, if I get some time to do it.

A thought:
When adding a constraint today, each add will bump the version of the delta table (new log entry). If adding a HashMap, should it bump the version once with multiple commit infos in the same log or provide a new log entry for each key in the map?

It should bump the version once, since we update the constraints hash map in the metadata in one go

@ion-elgreco ion-elgreco added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 7, 2024
@DevChrisCross
Copy link
Contributor

Take

@Nordalf
Copy link
Contributor

Nordalf commented Jan 20, 2025

Take

Sweet!

@DevChrisCross
Copy link
Contributor

I haven't started this one yet since I became too busy, hopefully could start it this week! :)

@Nordalf
Copy link
Contributor

Nordalf commented Jan 20, 2025

No rush! Take your time, mate 🚀

@ion-elgreco
Copy link
Collaborator Author

@DevChrisCross are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants