Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle illegal charactes for Windows paths #1215

Closed
Blajda opened this issue Mar 10, 2023 · 0 comments
Closed

Handle illegal charactes for Windows paths #1215

Blajda opened this issue Mar 10, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Blajda
Copy link
Collaborator

Blajda commented Mar 10, 2023

Environment

Delta-rs version: Rust
Binding: main

Environment:

  • OS: Windows

Bug

What happened:
When delta-rs tries to write a timestamp partition on Windows it fails with the following error.

test timestamp
thread 'test_files_scanned' panicked at 'called `Result::unwrap()` on an `Err` value: ObjectStore { source: Generic { store: "LocalFileSystem", source: UnableToCreateFile { path: "C:\\Users\\runneradmin\\AppData\\Local\\Temp\\.tmpKm0Y2T\\timestamp=1970-01-01 00:00:00\\part-00000-537f4856-39e3-4058-895a-a726fcf769ae-c000.snappy.parquet", err: Os { code: 123, kind: InvalidFilename, message: "The filename, directory name, or volume label syntax is incorrect." } } } }', rust\tests\datafusion_test.rs:89:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This occurs since the following characters are illegal for a path in windows. < > ? [ ] : | *
This likely is also an issue with the string column too

What you expected to happen:
Writing timestamp columns on Windows should work. We also need to handle any other illegal value in the path.
The solution should conform to Spark's behavior and end users should only use the partition value from the Delta log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants