-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure chains in authservice don't get reordered and cause checksum changes #944
Comments
I believe an easy fix would be to deterministically sort the chains of the authservice config so the checksum was consistent even if the Pepr watcher pod restarted. See this function - uds-core/src/pepr/operator/controllers/keycloak/authservice/authservice.ts Lines 78 to 94 in 2f63db2
I frequently use this one liner to take a quick peak at which chains are currently stored in the secret if its helpful -
|
I opened #969 which should hopefully address this going forward by sorting the chains when they're added. |
Hey @brianrexrode - we recently merged #969 to consistently sort the chains, which should address this issue going forward. Note that updating to the version that eventually contains this fix will still cause the issue as the current sorting of the chains would then be re-done, but after that there shouldn't be an issue. Thanks! |
Environment
Device and OS: Linux x86_64
App version: v0.28.0
Kubernetes distro being used: 1.30.1
Other:
Steps to reproduce
Expected result
pepr-watcher only updates the authservice-uds secret if something has changed and restart authservice pods accordingly
Actual Result
pepr-watcher may or may not reorder the chains in the authservice-uds secret regardless if any changes were made which causes the watcher to restart the authservice pod(s) for no reason.
This results in any active users being required to generate a new session token.
Visual Proof (screenshots, videos, text, etc)
slack thread here
Severity/Priority
Additional Context
Add any other context or screenshots about the technical debt here.
The text was updated successfully, but these errors were encountered: