-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hicDetectLoops normalisation method #433
Comments
Hi, In HiCExplorer we use the default way of the cooler file format to apply the correction factors. Unfortunately hic2cool and the hic format do not create these kind of matrices and you have to apply an additional step: run hicConvertFormat on the matrix from hic2cool and set the parameter —correction_name KR to move the correction factors of KR to the correct format. The output of this matrix will have the correction factors and these are applied from all HiCExplorer tools. For more information have a look at our documentation: https://hicexplorer.readthedocs.io/en/latest/content/tools/hicConvertFormat.html#cool-to-cool Best, Joachim |
Thank you for the extra information. I think I understand now; I can add the KR correction using hicConvertFormat as described in the doc and can make the cool file. Using the below snippet, I have a few issues
The first is that when I do the cool2cool step, I lose the 'Genome assembly' attribute that contained the path to the chrom.sizes file after hic2cool (via hicConvertFormat). Does that warning message indicate a problem with the files? The I am unable to use the Thanks for your help. |
Hi Christopher,
This is only some meta data that you don't need for analysis with HiCExplorer. If this information is needed it is quite easy to retrieve it from our internal datastructures. However, I agree with you that we should not remove it and I will fix this with an update.
No, not really a problem. The default assumption is that the 'count' data is stored as an integer, and therefore we give out this warning in cases we store floats. With HiCExplorer using floats is no issue at all, this warning is more for users who use the cool files with other software which maybe depend on integers. For the same reason we offer the
You should be able to apply it if it was provided for this resolution by the hic format. If you are sure the factors are available to get somewhere an inf is an indicator that we could have somewhere a bug. Did you use a public data set where this happens? Maybe I can reproduce this error, it would make it easier for me to fix this. Best, Joachim |
Thank you for the clarifications. The 'Normalizations' attribute does list it so I guess it should be usable.
I have made a copy of a Thanks again, Chris |
Hi Joachim, @joachimwolff Thanks! |
Which normalisation method is used by hicDetectLoops? I have a cooler that I converted from a Juicer hic:
I guess it is the first in the list, so KR? Is there any way to change the normalisation that is used - I can't see anything about this in the docs.
The text was updated successfully, but these errors were encountered: