Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hicAdjustMatrix new mode: keepByMasking #341

Closed
gtrichard opened this issue Feb 4, 2019 · 1 comment · Fixed by #572
Closed

hicAdjustMatrix new mode: keepByMasking #341

gtrichard opened this issue Feb 4, 2019 · 1 comment · Fixed by #572
Labels
enhancement Feature request release 3.1

Comments

@gtrichard
Copy link
Collaborator

hicAdjustMatrix is currently removing bins when --action keep is specified. If someone uses a BED file of many regions within a chromosome, the adjusted matrix plotting is broken.

Therefore, hicAdjustMatrix should have 4 modes:

keepByMasking
keepByDeleting
removeByMasking
removeByDeleting

Although I'm not sure that keepByDeleting has many interest.
@LeilyR LeilyR mentioned this issue May 18, 2020
Open
19 tasks
@LeilyR
Copy link
Collaborator

LeilyR commented Jul 8, 2020

@gtrichard why cannot you use --action mask for that matter?

@LeilyR LeilyR mentioned this issue Jul 10, 2020
Merged
2 tasks
@joachimwolff joachimwolff mentioned this issue Jul 10, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature request release 3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Develop deeptools/HiCExplorer
3 participants
@joachimwolff @LeilyR @gtrichard