Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC ACK message format inconsistent #408

Closed
jdmnd opened this issue Oct 19, 2016 · 0 comments
Closed

RPC ACK message format inconsistent #408

jdmnd opened this issue Oct 19, 2016 · 0 comments

Comments

@jdmnd
Copy link
Contributor

jdmnd commented Oct 19, 2016

The RPC ACK message format is inconsistent with other types of message.

In the message specs generally, the name of an event/record/rpc is the third field of the message unless the message action is A(ACK) or E(ERROR), in which case it is the fourth field.
e.g.

R|D|recordName
R|A|D|recordName

However, RPC REQ(REQUEST) ACKs use the format P|A|rpcName|correlationId, with the rpcName in the third field. This is inconsistent with RPC S(SUBSCRIBE)/US(UNSUBSCRIBE) ACKs that have the rpcName in the fourth field: P|A|S|rpcName.

This makes the message format difficult to parse, and may lead to unspecified behaviour, ACK_TIMEOUTs or UNSOLICITED_MESSAGE errors if RPCs are named "S" or "US".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants