We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I noticed while doing the exact opposite, i.e. removing necessary deepCopy, that subscribe actually leaks out _$data instead of calling this.get().
subscribe
_$data
this.get()
https://github.com/deepstreamIO/deepstream.io-client-js/blob/master/src/record/record.js#L191
args.callback( this._$data );
should be:
args.callback( this.get() );
The text was updated successfully, but these errors were encountered:
good catch! wana raise a pr?
Sorry, something went wrong.
record: Don't leak out _ to subscribed. Fixes deepstreamIO#202.
ddb03b3
f8341be
No branches or pull requests
I noticed while doing the exact opposite, i.e. removing necessary deepCopy, that
subscribe
actually leaks out_$data
instead of callingthis.get()
.https://github.com/deepstreamIO/deepstream.io-client-js/blob/master/src/record/record.js#L191
should be:
The text was updated successfully, but these errors were encountered: