Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe leaks out actual data reference #202

Closed
ronag opened this issue Aug 5, 2016 · 1 comment
Closed

Subscribe leaks out actual data reference #202

ronag opened this issue Aug 5, 2016 · 1 comment

Comments

@ronag
Copy link

ronag commented Aug 5, 2016

I noticed while doing the exact opposite, i.e. removing necessary deepCopy, that subscribe actually leaks out _$data instead of calling this.get().

https://github.com/deepstreamIO/deepstream.io-client-js/blob/master/src/record/record.js#L191

                args.callback( this._$data );

should be:

                args.callback( this.get() );
@yasserf
Copy link
Contributor

yasserf commented Aug 6, 2016

good catch! wana raise a pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants