Skip to content
This repository has been archived by the owner on Apr 6, 2021. It is now read-only.

make check / make test pre commit hook #43

Open
yasserf opened this issue Feb 16, 2017 · 2 comments
Open

make check / make test pre commit hook #43

yasserf opened this issue Feb 16, 2017 · 2 comments

Comments

@yasserf
Copy link
Contributor

yasserf commented Feb 16, 2017

No description provided.

@yasserf yasserf added the ready label Feb 16, 2017
@frobware
Copy link
Contributor

Do we not already have this? Every time I currently push a build runs before I can merge. Perhaps I misunderstood the title/description.

@yasserf
Copy link
Contributor Author

yasserf commented Feb 16, 2017

Ah, I thought you meant a pre commit hook that runs it locally first. Happy with relying on CI and PRs, usually we protect master and force builds to pass first before merging. Closing

@yasserf yasserf closed this as completed Feb 16, 2017
@yasserf yasserf removed the ready label Feb 16, 2017
@yasserf yasserf reopened this Feb 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frobware @yasserf