Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/asset/dcr: Switch to standalone.CheckTransactionSanity when updated module released. #1615

Open
davecgh opened this issue May 14, 2022 · 3 comments
Labels
wallet Client wallet backends

Comments

@davecgh
Copy link
Member

davecgh commented May 14, 2022

The following will need to be updated once a new version of the blockchain/standalone module is released since the blockchain package will eventually be moving internal.

if err = blockchain.CheckTransactionSanity(contractTx, dcr.chainParams); err != nil {

- err = blockchain.CheckTransactionSanity(contractTx, dcr.chainParams) 
+ err = standalone.CheckTransactionSanity(contractTx, dcr.chainParams.MaxTxSize) 
@chappjc chappjc added wallet Client wallet backends and removed Go labels Dec 29, 2022
@buck54321
Copy link
Member

Looks like we're still using blockchain.CheckTransactionSanity in one place on the client. Is this OK?

@davecgh
Copy link
Member Author

davecgh commented Nov 3, 2023

The function was removed as of blockchain/v5 and instead moved to standalone/v2.

It should be updated as suggested to use the latest code.

@peterzen
Copy link
Member

peterzen commented Jan 23, 2024

It should be updated as suggested to use the latest code.

This change is in place:

if err = blockchain.CheckTransactionSanity(contractTx, uint64(dcr.chainParams.MaxTxSize)); err != nil {

blockchain "github.com/decred/dcrd/blockchain/standalone/v2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wallet Client wallet backends
Projects
None yet
Development

No branches or pull requests

4 participants