[linstor-csi-plugin] add params nil check

Signed-off-by: Slava V <[email protected]>

Author: MrTomSawyer

images/linstor-csi/src/pkg/linstor/highlevelclient/high_level_client.go

@@ -62,39 +62,36 @@ func NewHighLevelClient(options ...lapi.Option) (*HighLevelClient, error) {
 // GenericAccessibleTopologies returns topologies based on linstor storage pools
 // and whether a resource is allowed to be accessed over the network.
 func (c *HighLevelClient) GenericAccessibleTopologies(ctx context.Context, volId string, remoteAccessPolicy volume.RemoteAccessPolicy, params *volume.AccessibleTopologiesParams) ([]*csi.Topology, error) {
-	var zones, nodeNames []string
-	var volumeAccess, topology string
-
-	if params != nil {
-		zones = params.SCZones
-		volumeAccess = params.SCVolumeAccess
-		topology = params.SCTopology
+	if params == nil {
+		return nil, fmt.Errorf("params must not be nil")
 	}
 
 	r, err := c.Resources.GetAll(ctx, volId)
 	if err != nil {
 		return nil, fmt.Errorf("unable to determine AccessibleTopologies: %v", err)
 	}
-
-	switch volumeAccess {
+	
+	var nodeNames []string
+	switch params.SCVolumeAccess {
 	case "PreferablyLocal", "EventuallyLocal", "Any":
-		if topology == "TransZonal" {
-			res := make([]*csi.Topology, len(zones))
-			for i, zone := range zones {
+		switch params.SCTopology {
+		case "TransZonal":
+			res := make([]*csi.Topology, len(params.SCZones))
+			for i, zone := range params.SCZones {
 				res[i] = &csi.Topology{Segments: map[string]string{"topology.kubernetes.io/zone": zone}}
 			}
 			return res, nil
-		}
-		if topology == "Zonal" {
+		case "Zonal":
 			nodeNames = util.DeployedDiskfullyNodes(r)
-		}
-		if topology == "Ignored" {
+		case "Ignored":
 			return []*csi.Topology{}, nil
+		default:
+			return nil, fmt.Errorf("invalid topology: %s", params.SCTopology)
 		}
 	case "Local":
 		nodeNames = util.DeployedDiskfullyNodes(r)
 	default:
-		return nil, fmt.Errorf("invalid volume access policy: %s", volumeAccess)
+		return nil, fmt.Errorf("invalid volume access policy: %s", params.SCVolumeAccess)
 	}
 
 	nodes, err := c.Nodes.GetAll(ctx, &lapi.ListOpts{Node: nodeNames})