feat: add verify metadata content option #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meelrossi
force-pushed
the
feat/add-verify-metadata-content-opt
branch
3 times, most recently
from
43274e0 to
be9ede1
Compare
| @@ -193,6 +193,16 @@ export default async function verify<P extends {} = {}>( | |||
| const ownerAddress = await verifySign(authChain, payload, options) | |||
| await verifyExpiration(timestamp, options) | |||
|
|
|||
| if ( | |||
| options.verifyMetadataContent && | |||
There was a problem hiding this comment.
Should this be checked only if the metadata header is set?
meelrossi
force-pushed
the
feat/add-verify-metadata-content-opt
branch
from
be9ede1 to
5824cd3
Compare
LautaroPetaccio
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new property to verify functino options to be able to add a custom verification for metadata