Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Override should not change method signature #178

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Conversation

kkriske
Copy link
Contributor

@kkriske kkriske commented Oct 26, 2017

when subclassing DefaultPluginManager you are forced to create a CompoundPluginDescriptorFinder even if you only need one

when subclassing `DefaultPluginManager` you are forced to create a `CompoundPluginDescriptorFinder` even if you only need one
@coveralls
Copy link

coveralls commented Oct 26, 2017

Coverage Status

Coverage decreased (-0.02%) to 56.957% when pulling a1e36b3 on kkriske:patch-1 into 468abf3 on decebals:master.

@decebals
Copy link
Member

Initial, my intention was to change the return value for all methods that return internally a Compound class implementation. The idea was to avoid a cast in subclass. The construction is OK from Java point of view.
In the end I think that it's good to preserve the original method signature without to alter the return value.

@decebals decebals merged commit a30c05b into pf4j:master Oct 26, 2017
@decebals
Copy link
Member

Thanks!

@kkriske kkriske deleted the patch-1 branch October 26, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants