From fa218faf209add599cc83c5d20dce72a521156fc Mon Sep 17 00:00:00 2001 From: DecafDev <40307803+decaf-dev@users.noreply.github.com> Date: Thu, 12 Sep 2024 19:25:03 -0600 Subject: [PATCH 1/4] fix: move clear button to bottom --- .../shared/components/search-select.svelte | 53 ++++++++++--------- 1 file changed, 29 insertions(+), 24 deletions(-) diff --git a/src/svelte/shared/components/search-select.svelte b/src/svelte/shared/components/search-select.svelte index 8c04da7f..6a8b5c46 100644 --- a/src/svelte/shared/components/search-select.svelte +++ b/src/svelte/shared/components/search-select.svelte @@ -157,21 +157,30 @@ bind:this={dropdownRef} use:portalAction > - {#each filteredOptions as option, i} -
handleOptionClick(option)} - on:keydown={() => {}} - > - {option} -
- {/each} +
+ {#each filteredOptions as option, i} +
handleOptionClick(option)} + on:keydown={() => {}} + > + {option} +
+ {/each} + {#if filteredOptions.length === 0} +
+ No results found +
+ {/if} +
{#if filteredOptions.length > 0}
{/if} - {#if filteredOptions.length === 0} -
- No results found -
- {/if}
{/if} @@ -211,8 +213,6 @@ position: absolute; background-color: var(--dropdown-background); box-shadow: var(--input-shadow); - max-height: 175px; - overflow-y: auto; z-index: 999; color: var(--text-normal); font-size: var(--font-ui-small); @@ -221,6 +221,11 @@ border-radius: var(--input-radius); } + .vault-explorer-search-select__dropdown-container { + max-height: 145px; + overflow-y: auto; + } + .vault-explorer-search-select__input-icon { position: absolute; top: 50%; From 31579e21248e61db88211580edb1d59a9e9ee127 Mon Sep 17 00:00:00 2001 From: DecafDev <40307803+decaf-dev@users.noreply.github.com> Date: Thu, 12 Sep 2024 19:26:48 -0600 Subject: [PATCH 2/4] fix: reset input to selected value on close --- src/svelte/shared/components/search-select.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/svelte/shared/components/search-select.svelte b/src/svelte/shared/components/search-select.svelte index 6a8b5c46..22cff4d3 100644 --- a/src/svelte/shared/components/search-select.svelte +++ b/src/svelte/shared/components/search-select.svelte @@ -42,7 +42,7 @@ function closeDropdown() { isOpen = false; - inputValue = ""; + inputValue = value; currentFocusIndex = 0; } From 8bf3c5b0cf624509e9c81cfb1693d9f7acc7a241 Mon Sep 17 00:00:00 2001 From: DecafDev <40307803+decaf-dev@users.noreply.github.com> Date: Thu, 12 Sep 2024 19:27:13 -0600 Subject: [PATCH 3/4] fix: only show clear button when a value has been selected --- src/svelte/shared/components/search-select.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/svelte/shared/components/search-select.svelte b/src/svelte/shared/components/search-select.svelte index 22cff4d3..b88107d2 100644 --- a/src/svelte/shared/components/search-select.svelte +++ b/src/svelte/shared/components/search-select.svelte @@ -181,7 +181,7 @@ {/if} - {#if filteredOptions.length > 0} + {#if value !== ""}
Date: Thu, 12 Sep 2024 19:28:27 -0600 Subject: [PATCH 4/4] chore: bump version --- manifest.json | 2 +- package.json | 2 +- versions.json | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/manifest.json b/manifest.json index 20c02a89..839c296f 100644 --- a/manifest.json +++ b/manifest.json @@ -1,7 +1,7 @@ { "id": "vault-explorer", "name": "Vault Explorer", - "version": "1.44.5", + "version": "1.44.6", "minAppVersion": "1.4.13", "description": "Explore your vault in visual format", "author": "DecafDev", diff --git a/package.json b/package.json index bebf623d..09b02272 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "obsidian-vault-explorer", - "version": "1.44.5", + "version": "1.44.6", "description": "Explore your vault in visual format", "main": "main.js", "scripts": { diff --git a/versions.json b/versions.json index db7c6755..4b925978 100644 --- a/versions.json +++ b/versions.json @@ -146,5 +146,6 @@ "1.44.2": "1.4.13", "1.44.3": "1.4.13", "1.44.4": "1.4.13", - "1.44.5": "1.4.13" + "1.44.5": "1.4.13", + "1.44.6": "1.4.13" }