Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include gtest as a Git submodule #720

Closed
shymega opened this issue May 30, 2020 · 2 comments
Closed

Include gtest as a Git submodule #720

shymega opened this issue May 30, 2020 · 2 comments
Labels
build-infra Build infrastructure bugs/PRs

Comments

@shymega
Copy link

shymega commented May 30, 2020 •
edited
Loading

Currently we bundle gtest with Barrier. This isn't ideal, and we should look to include it as a Git submodule locked at a specific Git tag/hash.

See #719.
@shymega shymega mentioned this issue May 30, 2020
Merged
@github-actions
Copy link

This issue has been automatically marked as stale due to inactivity. It will be closed if no further activity occurs. Thank you for your contributions.

@shymega
Copy link
Author

shymega commented Sep 20, 2020 •
edited
Loading

We actually did complete this, so closing. Commit ref: 938ad34.

@shymega shymega closed this as completed Sep 20, 2020
@shymega shymega added build-infra Build infrastructure bugs/PRs and removed no-issue-activity labels Sep 20, 2020
@ghost ghost mentioned this issue Nov 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build-infra Build infrastructure bugs/PRs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shymega