Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted unnecessary checks if certain fields were None #13

Closed
wants to merge 1 commit into from

Conversation

cjappl
Copy link

@cjappl cjappl commented May 1, 2021

Closes #11
#7
#8

@cjappl
Copy link
Author

cjappl commented May 2, 2021

I think #9 is the much more correct way of doing this, and should be preferred if you have the chance to merge that.

@jazzmoe
Copy link

jazzmoe commented May 22, 2021

I encountered the same issues as in #8 and would appreaciate a merge if @cjappl 's fix solves the issue

Also I am pretty new to coding in python - can I somehow use your fix as a module @cjappl without waiting for a merge in this project?

@cjappl
Copy link
Author

cjappl commented May 22, 2021 via email

@jazzmoe
Copy link

jazzmoe commented May 22, 2021

I'd like to contribute - I actively try to build a useful application linking my different bank accounts to ynab. Can I somehow download your version to my python package folder. How would that work?

@cjappl
Copy link
Author

cjappl commented May 22, 2021

@jazzmoe you can find my fork here

https://github.com/cjappl/ynab-python

You can install directly with

pip install git+https://github.com/cjappl/ynab-python.git

Or, you can clone the repo, navigate to the top level directory and install locally

git clone https://github.com/cjappl/ynab-python
cd ynab-python
pip install -e .

If you have any issues, head over to my fork and report it, we can work on it together!

@ohare93
Copy link

ohare93 commented Jun 9, 2021

Lovely, thank you for this easy fix 👍

@cjappl
Copy link
Author

cjappl commented Apr 1, 2022

Closing, seems like this repo is dead. RIP

@cjappl cjappl closed this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TransactionDetail has optional fields marked as required
3 participants