From e45e4c755b59b7f1b918c2065b5d7eabbf0feec4 Mon Sep 17 00:00:00 2001 From: Lars Vogel Date: Fri, 17 Sep 2021 11:21:05 +0200 Subject: [PATCH 01/17] Maven setup Currently not building anything just setting up the build and Github action Using the target platform during the Maven build and build the css plug-in --- .github/workflows/maven.yml | 23 ++++++++ .mvn/extensions.xml | 8 +++ pom.xml | 106 ++++++++++++++++++++++++++++++++++++ 3 files changed, 137 insertions(+) create mode 100644 .github/workflows/maven.yml create mode 100644 .mvn/extensions.xml create mode 100644 pom.xml diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml new file mode 100644 index 00000000..0496c948 --- /dev/null +++ b/.github/workflows/maven.yml @@ -0,0 +1,23 @@ +# This workflow will build a Java project with Maven +# For more information see: https://help.github.com/actions/language-and-framework-guides/building-and-testing-java-with-gradle + +name: Java CI with Maven +on: + push: + branches-ignore: + - documentation + +jobs: + build: + + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v2 + - name: Set up JDK 11 + uses: actions/setup-java@v2 + with: + distribution: 'adopt' + java-version: '11' + - name: Build with Maven + run: mvn clean verify diff --git a/.mvn/extensions.xml b/.mvn/extensions.xml new file mode 100644 index 00000000..cfc4f26b --- /dev/null +++ b/.mvn/extensions.xml @@ -0,0 +1,8 @@ + + + + org.eclipse.tycho.extras + tycho-pomless + 2.4.0 + + \ No newline at end of file diff --git a/pom.xml b/pom.xml new file mode 100644 index 00000000..de6ff2d9 --- /dev/null +++ b/pom.xml @@ -0,0 +1,106 @@ + + 4.0.0 + eclipse.asciidoctor.editor + releng + 1.0.0-SNAPSHOT + pom + + + + tycho-snapshots + https://repo.eclipse.org/content/repositories/tycho-snapshots/ + + + + + 2.5.0-SNAPSHOT + UTF-8 + + + + + + + + + org.eclipse.tycho + tycho-p2-director-plugin + ${tycho.version} + + + + + + + org.eclipse.tycho + tycho-maven-plugin + ${tycho.version} + true + + + + org.eclipse.tycho + tycho-packaging-plugin + ${tycho.version} + + + package + package-feature + + ${project.artifactId}_${unqualifiedVersion}.${buildQualifier} + + + + + + org.eclipse.tycho + target-platform-configuration + ${tycho.version} + + + ../asciidoctor-editor-target/asciidoctor-editor.target + + false + + + + linux + gtk + x86_64 + + + win32 + win32 + x86_64 + + + macosx + cocoa + x86_64 + + + + + + + + + + asciidoctor-editor-css + + + + + \ No newline at end of file From 9d63adef76f86288f9cc1b399fa53ad6caa0112c Mon Sep 17 00:00:00 2001 From: Lars Vogel Date: Tue, 28 Sep 2021 09:55:04 +0200 Subject: [PATCH 02/17] Updating the releng pom version No functional impact but suggested by @de-jcup For #371 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index de6ff2d9..27acf9d1 100644 --- a/pom.xml +++ b/pom.xml @@ -2,7 +2,7 @@ 4.0.0 eclipse.asciidoctor.editor releng - 1.0.0-SNAPSHOT + 2.5.0-SNAPSHOT pom From 61d4a57e6361caf372cae9bdb4f2d4c57436cf10 Mon Sep 17 00:00:00 2001 From: Lars Vogel Date: Tue, 28 Sep 2021 10:13:33 +0200 Subject: [PATCH 03/17] Remove minimum version from asciidoctor-editor-plugin Search and refactoring were the only plug-ins defining a minimum version and this version did not fit to the target platform. By removing the version we enable the plug-in to resolve them with the giving target platform. --- asciidoctor-editor-plugin/META-INF/MANIFEST.MF | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/asciidoctor-editor-plugin/META-INF/MANIFEST.MF b/asciidoctor-editor-plugin/META-INF/MANIFEST.MF index a92d272a..9a8ca1f5 100644 --- a/asciidoctor-editor-plugin/META-INF/MANIFEST.MF +++ b/asciidoctor-editor-plugin/META-INF/MANIFEST.MF @@ -19,9 +19,9 @@ Require-Bundle: org.eclipse.ui, org.eclipse.ui.console, de.jcup.asciidoctoreditor.libs, de.jcup.asciidoctoreditor.css, - org.eclipse.search;bundle-version="3.11.400", + org.eclipse.search, org.eclipse.ltk.ui.refactoring, - org.eclipse.ltk.core.refactoring;bundle-version="3.9.200" + org.eclipse.ltk.core.refactoring Bundle-RequiredExecutionEnvironment: JavaSE-1.8 Bundle-ActivationPolicy: lazy Import-Package: org.eclipse.ui, From ea7c5a83b7a6f63ac54647d64818e6fd4fe5d333 Mon Sep 17 00:00:00 2001 From: Lars Vogel Date: Thu, 20 Jan 2022 10:26:48 +0100 Subject: [PATCH 04/17] Build with release Tycho version --- pom.xml | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/pom.xml b/pom.xml index 27acf9d1..71992ac8 100644 --- a/pom.xml +++ b/pom.xml @@ -5,19 +5,11 @@ 2.5.0-SNAPSHOT pom - - - tycho-snapshots - https://repo.eclipse.org/content/repositories/tycho-snapshots/ - - - - 2.5.0-SNAPSHOT + 2.5.0 UTF-8 - From a13d8033215799ab24d91b1b869aed1da36b61d8 Mon Sep 17 00:00:00 2001 From: Lars Vogel Date: Fri, 21 Jan 2022 10:07:46 +0100 Subject: [PATCH 05/17] Build against 2021-12 Eclipse release This should help with solving the strange version range issue. --- asciidoctor-editor-target/asciidoctor-editor.target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/asciidoctor-editor-target/asciidoctor-editor.target b/asciidoctor-editor-target/asciidoctor-editor.target index eaac4181..bd2c7533 100644 --- a/asciidoctor-editor-target/asciidoctor-editor.target +++ b/asciidoctor-editor-target/asciidoctor-editor.target @@ -2,7 +2,7 @@ - + \ No newline at end of file From 6764ef215641fd8dbe36c85c4372b5be5741d866 Mon Sep 17 00:00:00 2001 From: de-jcup Date: Fri, 4 Feb 2022 22:32:13 +0100 Subject: [PATCH 06/17] Added maven dependencies #371 - added commons-io 2.7 (originally used io 2.6 but had a vulnerability so used 2.7 now to too many issues with upgrade at the moment - added eclipse-commons 1.0.0 dependency - added asciidoctor j launcher dependency --- .../asciidoctor-editor.target | 33 ++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/asciidoctor-editor-target/asciidoctor-editor.target b/asciidoctor-editor-target/asciidoctor-editor.target index bd2c7533..048a4cfe 100644 --- a/asciidoctor-editor-target/asciidoctor-editor.target +++ b/asciidoctor-editor-target/asciidoctor-editor.target @@ -1,8 +1,39 @@ - + + + + + + + + + de.jcup.asp + asp-server-asciidoctorj-launcher + 1.3.1 + + + + de.jcup.eclipse.commons + eclipse-commons + 1.0.0 + + + + + commons-io + commons-io + 2.7 + + + + + \ No newline at end of file From 8a70eae5750a1c66da4f9ab0411add3ee455ecdc Mon Sep 17 00:00:00 2001 From: de-jcup Date: Fri, 4 Feb 2022 22:37:42 +0100 Subject: [PATCH 07/17] Added target to .gitignore for css plugin #371 --- asciidoctor-editor-css/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/asciidoctor-editor-css/.gitignore b/asciidoctor-editor-css/.gitignore index b68da18e..1d12b437 100644 --- a/asciidoctor-editor-css/.gitignore +++ b/asciidoctor-editor-css/.gitignore @@ -1,3 +1,4 @@ +target !.metadata !.classpath !.project From 7853cbfb6baa425e7b39b271ee3395e1cefa9753 Mon Sep 17 00:00:00 2001 From: de-jcup Date: Fri, 4 Feb 2022 23:02:54 +0100 Subject: [PATCH 08/17] Added asp-server-asciidoctorj dependencies + lib dependencies #371 - unfortunately the runtime dependencies (asciidoctorj for example) seems to be not resolved by asciidoctor-editor-target --- asciidoctor-editor-libs/META-INF/MANIFEST.MF | 1 + asciidoctor-editor-plugin/.classpath | 2 -- .../META-INF/MANIFEST.MF | 12 +++++--- asciidoctor-editor-plugin/build.properties | 4 +-- .../asciidoctor-editor.target | 29 ++++++++++--------- 5 files changed, 26 insertions(+), 22 deletions(-) diff --git a/asciidoctor-editor-libs/META-INF/MANIFEST.MF b/asciidoctor-editor-libs/META-INF/MANIFEST.MF index 9cf7a2ab..ab439731 100644 --- a/asciidoctor-editor-libs/META-INF/MANIFEST.MF +++ b/asciidoctor-editor-libs/META-INF/MANIFEST.MF @@ -6,3 +6,4 @@ Bundle-Version: 2.3.0 Bundle-Vendor: Albert Tregnaghi Bundle-RequiredExecutionEnvironment: JavaSE-1.8 Automatic-Module-Name: de.jcup.asciidoctoreditor.libs +Require-Bundle: wrapped.de.jcup.asp.asp-server-asciidoctorj;bundle-version="1.3.1" diff --git a/asciidoctor-editor-plugin/.classpath b/asciidoctor-editor-plugin/.classpath index 7ec5ff16..aa6b5fd5 100644 --- a/asciidoctor-editor-plugin/.classpath +++ b/asciidoctor-editor-plugin/.classpath @@ -6,8 +6,6 @@ - - diff --git a/asciidoctor-editor-plugin/META-INF/MANIFEST.MF b/asciidoctor-editor-plugin/META-INF/MANIFEST.MF index 9a8ca1f5..aa4fa934 100644 --- a/asciidoctor-editor-plugin/META-INF/MANIFEST.MF +++ b/asciidoctor-editor-plugin/META-INF/MANIFEST.MF @@ -21,14 +21,18 @@ Require-Bundle: org.eclipse.ui, de.jcup.asciidoctoreditor.css, org.eclipse.search, org.eclipse.ltk.ui.refactoring, - org.eclipse.ltk.core.refactoring + org.eclipse.ltk.core.refactoring, + wrapped.de.jcup.asp.asp-server-asciidoctorj-launcher;bundle-version="1.3.1", + eclipse-commons;bundle-version="1.0.0", + org.apache.commons.commons-io;bundle-version="2.7.0", + wrapped.de.jcup.asp.asp-core;bundle-version="1.3.1", + wrapped.de.jcup.asp.asp-client-java;bundle-version="1.3.1", + wrapped.de.jcup.asp.asp-api;bundle-version="1.3.1" Bundle-RequiredExecutionEnvironment: JavaSE-1.8 Bundle-ActivationPolicy: lazy Import-Package: org.eclipse.ui, org.eclipse.ui.texteditor.spelling, org.eclipse.ui.texteditor.templates Bundle-ClassPath: ., - lib/de-jcup-eclipse-commons.jar, - lib/commons-io-2.6.jar, - lib/asp-server-asciidoctorj-launcher-dist.jar + lib/de-jcup-eclipse-commons.jar Automatic-Module-Name: de.jcup.asciidoctoreditor diff --git a/asciidoctor-editor-plugin/build.properties b/asciidoctor-editor-plugin/build.properties index 77a55e73..fb375621 100644 --- a/asciidoctor-editor-plugin/build.properties +++ b/asciidoctor-editor-plugin/build.properties @@ -12,9 +12,7 @@ bin.includes = META-INF/,\ tooltips/,\ addons/,\ css/,\ - lib/de-jcup-eclipse-commons.jar,\ - lib/commons-io-2.6.jar,\ - lib/asp-server-asciidoctorj-launcher-dist.jar + lib/de-jcup-eclipse-commons.jar src.excludes = src/test/java-eclipse/,\ src/test/java/,\ src/test/resources/ diff --git a/asciidoctor-editor-target/asciidoctor-editor.target b/asciidoctor-editor-target/asciidoctor-editor.target index 048a4cfe..47162500 100644 --- a/asciidoctor-editor-target/asciidoctor-editor.target +++ b/asciidoctor-editor-target/asciidoctor-editor.target @@ -6,34 +6,37 @@ - - + + commons-io + commons-io + 2.7 + jar + de.jcup.asp asp-server-asciidoctorj-launcher 1.3.1 + jar - de.jcup.eclipse.commons eclipse-commons 1.0.0 + jar - - + + + + - commons-io - commons-io - 2.7 + de.jcup.asp + asp-server-asciidoctorj + 1.3.1 + jar - - \ No newline at end of file From 5f109d971fb39278e0febefe97903460b7ce7341 Mon Sep 17 00:00:00 2001 From: de-jcup Date: Fri, 25 Mar 2022 10:46:42 +0100 Subject: [PATCH 09/17] changes on build ... #371 --- asciidoctor-editor-plugin/.classpath | 1 - asciidoctor-editor-plugin/META-INF/MANIFEST.MF | 8 +++----- asciidoctor-editor-plugin/build.properties | 3 +-- asciidoctor-editor-target/asciidoctor-editor.target | 4 ++-- pom.xml | 1 + 5 files changed, 7 insertions(+), 10 deletions(-) diff --git a/asciidoctor-editor-plugin/.classpath b/asciidoctor-editor-plugin/.classpath index aa6b5fd5..6b2f8275 100644 --- a/asciidoctor-editor-plugin/.classpath +++ b/asciidoctor-editor-plugin/.classpath @@ -9,6 +9,5 @@ - diff --git a/asciidoctor-editor-plugin/META-INF/MANIFEST.MF b/asciidoctor-editor-plugin/META-INF/MANIFEST.MF index aa4fa934..7fa47998 100644 --- a/asciidoctor-editor-plugin/META-INF/MANIFEST.MF +++ b/asciidoctor-editor-plugin/META-INF/MANIFEST.MF @@ -17,22 +17,20 @@ Require-Bundle: org.eclipse.ui, org.eclipse.ui.ide, org.eclipse.core.expressions, org.eclipse.ui.console, - de.jcup.asciidoctoreditor.libs, de.jcup.asciidoctoreditor.css, org.eclipse.search, org.eclipse.ltk.ui.refactoring, org.eclipse.ltk.core.refactoring, - wrapped.de.jcup.asp.asp-server-asciidoctorj-launcher;bundle-version="1.3.1", eclipse-commons;bundle-version="1.0.0", org.apache.commons.commons-io;bundle-version="2.7.0", wrapped.de.jcup.asp.asp-core;bundle-version="1.3.1", wrapped.de.jcup.asp.asp-client-java;bundle-version="1.3.1", - wrapped.de.jcup.asp.asp-api;bundle-version="1.3.1" + wrapped.de.jcup.asp.asp-api;bundle-version="1.3.1", + wrapped.de.jcup.asp.asp-server-asciidoctorj-launcher;bundle-version="1.4.0" Bundle-RequiredExecutionEnvironment: JavaSE-1.8 Bundle-ActivationPolicy: lazy Import-Package: org.eclipse.ui, org.eclipse.ui.texteditor.spelling, org.eclipse.ui.texteditor.templates -Bundle-ClassPath: ., - lib/de-jcup-eclipse-commons.jar +Bundle-ClassPath: . Automatic-Module-Name: de.jcup.asciidoctoreditor diff --git a/asciidoctor-editor-plugin/build.properties b/asciidoctor-editor-plugin/build.properties index fb375621..7b5847a4 100644 --- a/asciidoctor-editor-plugin/build.properties +++ b/asciidoctor-editor-plugin/build.properties @@ -11,8 +11,7 @@ bin.includes = META-INF/,\ toc.xml,\ tooltips/,\ addons/,\ - css/,\ - lib/de-jcup-eclipse-commons.jar + css/ src.excludes = src/test/java-eclipse/,\ src/test/java/,\ src/test/resources/ diff --git a/asciidoctor-editor-target/asciidoctor-editor.target b/asciidoctor-editor-target/asciidoctor-editor.target index 47162500..e3ec43fc 100644 --- a/asciidoctor-editor-target/asciidoctor-editor.target +++ b/asciidoctor-editor-target/asciidoctor-editor.target @@ -17,7 +17,7 @@ de.jcup.asp asp-server-asciidoctorj-launcher - 1.3.1 + 1.4.0 jar @@ -33,7 +33,7 @@ de.jcup.asp asp-server-asciidoctorj - 1.3.1 + 1.4.0 jar diff --git a/pom.xml b/pom.xml index 71992ac8..ca0a2602 100644 --- a/pom.xml +++ b/pom.xml @@ -79,6 +79,7 @@ asciidoctor-editor-css + asciidoctor-editor-plugin - \ No newline at end of file + From 4517ae423128079e68bae6fc116623deb2ebb0eb Mon Sep 17 00:00:00 2001 From: de-jcup Date: Sun, 28 Aug 2022 19:19:38 +0200 Subject: [PATCH 16/17] Using now Tycho 2.7.4 #371 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 97a0725b..ed29db8d 100644 --- a/pom.xml +++ b/pom.xml @@ -6,7 +6,7 @@ pom - 2.7.2 + 2.7.4 UTF-8 From 2460e8608a2c043305b2b3bfe66812febb3e4869 Mon Sep 17 00:00:00 2001 From: de-jcup Date: Sun, 28 Aug 2022 19:20:19 +0200 Subject: [PATCH 17/17] Added missing "." for bin.includes #371 - built main plugin did not contain any classes. The reason was the missing entry. --- asciidoctor-editor-plugin/build.properties | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/asciidoctor-editor-plugin/build.properties b/asciidoctor-editor-plugin/build.properties index e55507b6..e8691ee6 100644 --- a/asciidoctor-editor-plugin/build.properties +++ b/asciidoctor-editor-plugin/build.properties @@ -3,6 +3,7 @@ source.. = src/main/java-eclipse/,\ src/main/resources/ output.. = bin/ bin.includes = META-INF/,\ + .,\ plugin.xml,\ icons/,\ about.html,\ @@ -11,7 +12,7 @@ bin.includes = META-INF/,\ toc.xml,\ tooltips/,\ addons/,\ - css/ + css/ src.excludes = src/test/java-eclipse/,\ src/test/java/,\ src/test/resources/