Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html docs: "new" shown on pseudo-classes #1106

Closed
gordonwoodhull opened this issue Feb 15, 2016 · 2 comments
Closed

html docs: "new" shown on pseudo-classes #1106

gordonwoodhull opened this issue Feb 15, 2016 · 2 comments
Labels
Milestone

Comments

@gordonwoodhull
Copy link
Contributor

@mtraynham pointed out in #1101:

Minor caveat on #1097 (the classes). Both jsdoc2md and grunt-jsdoc (with docstrap) add the "new" keyword to these classes. Most of the documentation doesn't use it, but dc.js will work with/without the keyword...

For example, the HTML docs show new compositeChart(parent, chartGroup), which works but is not idiomatic for dc.js. (For that matter, one would have to specify dc.compositeChart)

It probably means an extra object is created only to be thrown away.

@gordonwoodhull gordonwoodhull added this to the v2.0 milestone Feb 15, 2016
@mtraynham
Copy link
Contributor

@gordonwoodhull
Copy link
Contributor Author

Meh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants