Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify variable scoping for macros #1928

Closed
1 task done
lostmygithubaccount opened this issue Aug 30, 2022 · 2 comments
Closed
1 task done

Clarify variable scoping for macros #1928

lostmygithubaccount opened this issue Aug 30, 2022 · 2 comments
Labels
content Improvements or additions to content Hackathon improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@lostmygithubaccount
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/docs/building-a-dbt-project/building-models/using-variables#defining-variables-in-dbt_projectyml

See dbt-labs/dbt-core#5587 for context

What part(s) of the page would you like to see updated?

Add a note/warning that a macro's context is derived from its calling model's project, not the one it is defined

Additional information

I can take a stab at making a PR for this
@lostmygithubaccount lostmygithubaccount added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Aug 30, 2022
@lostmygithubaccount lostmygithubaccount self-assigned this Aug 30, 2022
@lostmygithubaccount lostmygithubaccount mentioned this issue Aug 30, 2022
Closed
2 tasks
@isaacsantelli
Copy link

Looking at this !

@lostmygithubaccount lostmygithubaccount removed their assignment Jun 20, 2023
@lostmygithubaccount lostmygithubaccount closed this as not planned Won't fix, can't repro, duplicate, stale Jun 22, 2023
@jtcohen6
Copy link
Collaborator

was just about to resolve this with #3605 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content Improvements or additions to content Hackathon improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@runleonarun @jtcohen6 @isaacsantelli @lostmygithubaccount