Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid infinite recursion in macro state check #3957

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Avoid infinite recursion in macro state check #3957

merged 2 commits into from
Sep 27, 2021

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Sep 27, 2021

resolves #3904

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@jtcohen6 jtcohen6 changed the title Avoid infinite recursion in recursively_check_macros_modified Avoid infinite recursion in macro state check Sep 27, 2021
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jtcohen6 jtcohen6 merged commit 571beb1 into develop Sep 27, 2021
@jtcohen6 jtcohen6 deleted the fix/3904 branch September 27, 2021 15:43
jtcohen6 added a commit that referenced this pull request Sep 27, 2021
* Avoid infinite recursion in macro state check

* Add test case for infinite macro recursion
jtcohen6 added a commit that referenced this pull request Sep 27, 2021
* Avoid infinite recursion in macro state check

* Add test case for infinite macro recursion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite recursion when checking for modified upstream macro
2 participants