Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do Not Hang on Worker Thread Exceptions #9583

Closed
2 tasks done
peterallenwebb opened this issue Feb 15, 2024 · 0 comments · Fixed by #9585
Closed
2 tasks done

Do Not Hang on Worker Thread Exceptions #9583

peterallenwebb opened this issue Feb 15, 2024 · 0 comments · Fixed by #9585
Assignees
@peterallenwebb
Labels
bug Something isn't working

Comments

@peterallenwebb
Copy link
Contributor

peterallenwebb commented Feb 15, 2024 •
edited
Loading

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

For a while now, when there was an exception during the execution of one of dbt's implementations of BaseRunner, dbt would hang rather than crash or report the exception message.

Expected Behavior

When a node fails to execute with an exception, we should record the failure as we would any other node error, and proceed normally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterallenwebb peterallenwebb

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle exceptions during node execution more elegantly. dbt-labs/dbt-core
1 participant
@peterallenwebb