Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt build: Change the way we handle tests (if parent test fails then don't run non-test children) #3597

Closed
Tracked by #3452
iknox-fa opened this issue Jul 20, 2021 · 2 comments · Fixed by #3792
Closed
Tracked by #3452
Assignees
Milestone

Comments

@iknox-fa
Copy link
Contributor

iknox-fa commented Jul 20, 2021

This work was finished, however it had to be removed from the PR due to difficulties with how some (many) of our tests operate. Because the tests don't build a correct graph failures occurred when running those tests. The obvious fix is to re-write those tests but it was too many to do as part of the dbt build effort.

References:

@jtcohen6 jtcohen6 added this to the 0.20.1 milestone Jul 21, 2021
@jtcohen6 jtcohen6 changed the title Change the way we handle tests (if parent test fails then don't run non-test children) dbt build: Change the way we handle tests (if parent test fails then don't run non-test children) Jul 21, 2021
@jtcohen6 jtcohen6 modified the milestones: 0.20.1, Oh-Twenty-One Jul 22, 2021
@jtcohen6
Copy link
Contributor

It looks like the particular commits we'd want to cherry-pick and revive are 4dc2963 + aaac5ff

@jtcohen6
Copy link
Contributor

jtcohen6 commented Aug 4, 2021

Exit criteria via example:

  • model_a has two children: a unique test and model_b
  • The unique test should run before model_b
  • If the unique test fails, model_b should skip running
  • The overall dbt build command should keep running
18:49:43 | Concurrency: 1 threads (target='dev')
18:49:43 |
18:49:43 | 1 of 7 START view model dbt_jcohen.model_a........................ [RUN]
18:49:43 | 1 of 7 OK created model dbt_jcohen.model_a........................ [INSERT 2 in 0.09s]
18:49:43 | 2 of 7 START test unique_model_a_id............................... [RUN]
18:49:43 | 2 of 7 FAIL test unique_model_a_id................................ [FAIL in 0.12s]
18:49:43 | 3 of 7 SKIP relation model_b...................................... [SKIP]
18:49:43 | 4 of 7 START relation another_model............................... [START]
... and so on ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants