Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add time_granularity to metric spec #10376

Closed
3 tasks done
courtneyholcomb opened this issue Jun 27, 2024 · 0 comments · Fixed by #10378
Closed
3 tasks done

[Feature] Add time_granularity to metric spec #10376

courtneyholcomb opened this issue Jun 27, 2024 · 0 comments · Fixed by #10378
Assignees
@courtneyholcomb
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking enhancement New feature or request semantic Issues related to the semantic layer

Comments

@courtneyholcomb
Copy link
Contributor

courtneyholcomb commented Jun 27, 2024 •
edited by dbeatty10
Loading

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Add time_granularity to metric spec.
Currently, metric_time defaults to the smallest available granularity. Now that we're enabling sub-daily granularities, users will likely be surprised to see metric_time default to second or anything smaller than day. To enable users to continue defaulting to a more useful granularity while still enabling smaller granularities for a given time dimension, we will allow them to specify their time_granularity in the metric spec. This will default to day, ensuring that this is not a breaking change and the behavior of metric_time does not change until the user specifies a different granularity here.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response
@courtneyholcomb courtneyholcomb added enhancement New feature or request triage semantic Issues related to the semantic layer artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking labels Jun 27, 2024
@courtneyholcomb courtneyholcomb self-assigned this Jun 27, 2024
This was referenced Jun 27, 2024
Closed
Merged
@dbeatty10 dbeatty10 removed the triage label Jul 16, 2024
@dbeatty10 dbeatty10 changed the title [Feature] Add default_granularity to metric spec [Feature] Add time_granularity to metric spec Jul 16, 2024
@dbeatty10 dbeatty10 mentioned this issue Jul 16, 2024
Closed
@syou6162 syou6162 mentioned this issue Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@courtneyholcomb courtneyholcomb

Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking enhancement New feature or request semantic Issues related to the semantic layer
Projects
None yet
Milestone
No milestone
2 participants
@courtneyholcomb @dbeatty10