Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix py312 datetime.utcnow warning #896

Merged
merged 4 commits into from
Feb 19, 2024
Merged

fix py312 datetime.utcnow warning #896

merged 4 commits into from
Feb 19, 2024

Conversation

jorenham
Copy link
Contributor

@jorenham jorenham commented Feb 18, 2024

Chore that needs to be done:

  • Add newsfragment pipenv run towncrier create [issue_number].[type].rst

Types are defined in the pyproject.toml, issue_numer either from issue tracker or the Pull request number

@jorenham
Copy link
Contributor Author

Since there's no issue to be linked, I'm not sure what to do with the towncrier stuff.

@fizyk
Copy link
Collaborator

fizyk commented Feb 19, 2024

@jorenham re towncrier point to this pr

@jorenham
Copy link
Contributor Author

@fizyk done

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (22944af) 95.26% compared to head (52c1210) 95.32%.
Report is 18 commits behind head on main.

Files Patch % Lines
pytest_postgresql/retry.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
+ Coverage   95.26%   95.32%   +0.06%     
==========================================
  Files          13       13              
  Lines         401      428      +27     
==========================================
+ Hits          382      408      +26     
- Misses         19       20       +1     
Flag Coverage Δ
unittests 95.32% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fizyk fizyk merged commit d5e7fc0 into dbfixtures:main Feb 19, 2024
49 checks passed
@fizyk
Copy link
Collaborator

fizyk commented Feb 19, 2024

Thank you @jorenham

@jorenham jorenham deleted the patch-1 branch February 19, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants