You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#27 shows that after a certain amount of samples two things are going to happen
browserify is going to explode with max call stack error
something in flamer.js is going to blow the stack in the browser (again so many samples) once we get past the problem in 1
There's two approaches we can take
avoid blowing the stack - this will require a altering flamer.js (possibly sticking in a setTimeout or something, or failing that rewriting procedural style) and altering browserify (kinda super out of scope, but we may be able to tweak something, again with a setTimeout)
when the stack is blown, instruct the user to retry with the --large-sample flag, this will:
a. set the --stack-size flag via require('v8').setFlagsFromString (assuming stack-size is supported otherwise we'll have to spawn a sub process which adds complexity)
b. print out useful command to open flamgegraph in chrome with --js-flags "--stack-size 8024"
The text was updated successfully, but these errors were encountered:
also investigate stack folding that might give us more leeway here too (although we'd still want to handle case where even folded stacks blow the stack)
#27 shows that after a certain amount of samples two things are going to happen
There's two approaches we can take
a. set the --stack-size flag via require('v8').setFlagsFromString (assuming stack-size is supported otherwise we'll have to spawn a sub process which adds complexity)
b. print out useful command to open flamgegraph in chrome with --js-flags "--stack-size 8024"
The text was updated successfully, but these errors were encountered: