Skip to content

Commit 197aeac

Browse files
committed
Call #to_s on id when passed to enqueue
This will become necessary when Mongoid bumps to 4.0.0, so preemptively make this change now. Signed-off-by: David Celis <[email protected]>
1 parent a0e77bd commit 197aeac

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

lib/recommendable.rb

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ def query(klass, ids)
2424

2525
def enqueue(user_id)
2626
user_id = user_id.id if user_id.is_a?(Recommendable.config.user_class)
27+
user_id = user_id.to_s
2728

2829
if defined?(::Sidekiq)
2930
Recommendable::Workers::Sidekiq.perform_async(user_id)

lib/recommendable/helpers/calculations.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ def predict_for(user_id, klass, item_id)
169169
liked_by_set = Recommendable::Helpers::RedisKeyMapper.liked_by_set_for(klass, item_id)
170170
disliked_by_set = Recommendable::Helpers::RedisKeyMapper.disliked_by_set_for(klass, item_id)
171171
similarity_sum = 0.0
172-
172+
173173
similarity_sum += similarity_total_for(user_id, liked_by_set)
174174
similarity_sum -= similarity_total_for(user_id, disliked_by_set)
175175

@@ -180,7 +180,7 @@ def predict_for(user_id, klass, item_id)
180180
prediction = similarity_sum / (liked_by_count + disliked_by_count).to_f
181181
prediction.finite? ? prediction : 0.0
182182
end
183-
183+
184184
def similarity_total_for(user_id, set)
185185
similarity_set = Recommendable::Helpers::RedisKeyMapper.similarity_set_for(user_id)
186186
ids = Recommendable.redis.smembers(set)

0 commit comments

Comments
 (0)