Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xz dependency #39

Closed
bovine3dom opened this issue Dec 11, 2019 · 6 comments
Closed

xz dependency #39

bovine3dom opened this issue Dec 11, 2019 · 6 comments

Comments

@bovine3dom
Copy link

unxz must be on the path to build this package. This isn't available on all systems (e.g. Docker's "official" julia image https://github.com/docker-library/julia).

Is there a way to automatically pull in this dependency (or swap it for one that can be) during the build process?

@davidanthoff
Copy link
Owner

On Julia 1.3 the package now uses the new artifacts system, so I think this shouldn’t be an issue there anymore. Could you try that?

@bovine3dom
Copy link
Author

bovine3dom commented Dec 11, 2019

The issue is present on 1.3 - Dockerfile is here (includes a workaround) https://github.com/IntegratedTransportPlanning/gcvt/blob/master/src/backend/Dockerfile

xz isn't included in the artifacts. Hmm, maybe it's an upstream issue? I don't see any mention of xz in this repository at all.

Edit: hmm, I can't replicate it now with sudo docker run -it julia:1.3 # then ] add NodeJS. I'll do some more digging :)

@bovine3dom
Copy link
Author

I get the error with my {Project,Manifest}.toml but not if I just add NodeJS.jl, so this must be an upstream issue. Thanks for your time and sorry for the noise!

@bovine3dom
Copy link
Author

Aha, I found the issue - version 1.0 of NodeJS.jl was installed. It was installed as an indirect dependency of VegaLite. NodeJS.jl 1.1.1 works fine.

Might I suggest adding 1.1 to https://github.com/queryverse/VegaLite.jl/blob/2f0df458678400ba60a6d1ed85a101a731a52c95/Project.toml#L35 ?

@davidanthoff
Copy link
Owner

So specifying 1 there means that VegaLite.jl is compatible with all 1.x.y versions of NodeJS, including 1.1.1. So I suspect that all that was needed was an pkg> up on your project, right?

@bovine3dom
Copy link
Author

bovine3dom commented Dec 12, 2019

I'll give that a go today. I'm not sure the timeline quite makes sense as I added VegaLite 6 days ago, which is about a week after NodeJS.jl 1.1 was released. I don't understand why it picked NodeJS.jl 1.0.

Edit: yeah, pkg> up fixed it. I still can't quite wrap my head around why NodeJS.jl 1.0 was ever installed. Thanks for your time on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants