Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solver UI - Incorrect object gets added to solver in v0.3.8 #165

Closed
RodeoPerchaude opened this issue Oct 22, 2020 · 8 comments
Closed

Solver UI - Incorrect object gets added to solver in v0.3.8 #165

RodeoPerchaude opened this issue Oct 22, 2020 · 8 comments
Assignees
Labels
bug maya tool A user tool inside Maya.
Milestone

Comments

@RodeoPerchaude
Copy link

RodeoPerchaude commented Oct 22, 2020

Hello all, following a conversation with Patcha, I am creating a"ticket" on the board.
Let me know if I am doing it wrong, and thanks for looking into it eventually.
Aside from this issue, 0.38 has been really stable for me so far.
14-20 hours without issues.

Problem / Feature

When selecting an object and adding it to the solver output attributes, another unrelated object gets added in it's place.

Exemple:
selecting: characterBucky_001:R_arm_1_FK_CON
added to the solver: characterBucky_001:R_foot_IK_CON

Steps to Reproduce

31313123

Software Versions

Maya 2018.6

  • mmSolver version:
    0.38

  • Maya version:
    Maya 2018.6

  • Operating System (OS): Rodeo's centOs

@david-cattermole david-cattermole self-assigned this Oct 22, 2020
@david-cattermole david-cattermole added bug maya tool A user tool inside Maya. labels Oct 22, 2020
@david-cattermole david-cattermole added this to the v0.3.9 milestone Oct 22, 2020
@david-cattermole
Copy link
Owner

Hello Etienne,

This is obviously a bug, and was meant to be fixed by #153.
I'm not sure what's causing it (yet), but I will investigate and I will release a v0.3.9 as soon as I can.

Is it possible to send me a scene file that reproduces the problem?
I don't need models at all, just the outer rig controls - only enough to reproduce the problem.

If I don't have any scene file, I can still attempt to fix the problem blindly but I have not way of testing myself.
I could produce a new pre-release of v0.3.9 with my changes for Maya 2018 on (CentOS) Linux, then you can test and let me know?

David

@RodeoPerchaude
Copy link
Author

RodeoPerchaude commented Oct 23, 2020 via email

@david-cattermole
Copy link
Owner

@RodeoPerchaude

I have a possible solution to this problem, and it will be released in v0.3.9 (soon).

Once it's released, please let me know if the problem is fixed or not.

David

@RodeoPerchaude
Copy link
Author

My pleasure David, We will install 0.3.9 as soon as possible and see if the issue is resolved.
Merci!

@david-cattermole
Copy link
Owner

@RodeoPerchaude can you confirm if this is working for you? Or maybe try v0.3.10?

@david-cattermole
Copy link
Owner

I know a lot more information about this bug now! It seems the problem is caused by duplicate UUIDs on the nodes.

By default each node in Maya will have different UUID values. However, if you create a scene file with a UUID, A, then reference that scene file into another scene file the same node will have the same UUID because a referenced file is never changed - that is usually fine... However, when you reference in the same scene file you will have two referenced files, with two differently named nodes, with the same UUID.

A lot of mmSolver assumes that two nodes can always be fetched with the UUID, and there is only one node with the same UUID.
Now I realise this is not true. I will need to do some research to fix this issue... but at least I know what the problem is.

David

@david-cattermole david-cattermole changed the title Incorrect object gets added to solver in 0.38 Solver UI - Incorrect object gets added to solver in v0.3.8 Dec 7, 2020
@RodeoPerchaude
Copy link
Author

Thanks a lot for the detective work David and Patcha.
I will make sure we have proper and unique UUID on our rigs and we would be good to go!

david-cattermole added a commit that referenced this issue Dec 10, 2020
Issue #165.

Uses the already existing MPlug and converts this directly to a
node path.


Unlike the name UUID suggests, there are cases when multiple nodes
in the Maya scene have the same UUID.
david-cattermole added a commit that referenced this issue Dec 10, 2020
Fixes issue #165.

The most common occurrence is when the same rig is referenced into the
Maya scene more than once AND the rig was saved in Maya 2016+.

When saving in a Maya version that contains the UUID feature (introduced
in Maya 2016) the UUIDs are saved into the referenced file.
The UUIDs are then read from the referenced file and having the same
scene file loaded into Maya will cause duplicate UUIDs to exist.
@david-cattermole
Copy link
Owner

Hello @RodeoPerchaude,

I have researched this bug and I've implemented a fix which will be ready in v0.3.11 (hopefully out this weekend).

Just to be clear, forcing the rig to have unique UUIDs will not stop this problem happening 100%.

If you load the rig file Character.mb into your Maya scene twice, the
same controls in each respective reference will have the same UUID
and the bug will happen.

My fix will stop the duplicate UUIDs for Attributes in the Solver from causing weirdness.
Technically, although extremely impractical, this fix will not stop the same problem happening with Markers, Bundles, Cameras and Collections. It is assumed that users do not use Markers (etc) inside referenced scene files.

David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug maya tool A user tool inside Maya.
Projects
None yet
Development

No branches or pull requests

2 participants