Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Loading Scripts Improvements for bash variables #6

Open
denisekgosnell opened this issue Jan 22, 2020 · 0 comments
Open

Data Loading Scripts Improvements for bash variables #6

denisekgosnell opened this issue Jan 22, 2020 · 0 comments

Comments

@denisekgosnell
Copy link
Contributor

denisekgosnell commented Jan 22, 2020

This ticket requests two improvements:

  1. implement a more robust way to set the DSBULK_PATH variable
  2. rename DEST_KS into DEST_GRAPH
  3. update the READMEs to reflect the changes to usage

All scripts are written such way, so it's just enough to set DSBULK_PATH outside of the scripts and it will be picked up, for example, as DSBULK_PATH=.... data/ch4/load_ch4.sh.

Or just use export DSBULK_PATH=.... to set it. Another possibility is to add dsbulk-1.4...../bin to the PATH, like export PATH=path_to_dsbulk_bin:$PATH.

All of this is easier than to modify all scripts, like the current implementation requires.

Similar approach could be used for DEST_KS for every script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant