From e09c7f60e5162b232d87f26d212cc6505fa87e35 Mon Sep 17 00:00:00 2001 From: StevenLuMT Date: Tue, 29 Nov 2022 15:05:18 +0800 Subject: [PATCH] InterleavedLedgerStorage: safe release ByteBuf (#3674) Co-authored-by: lushiji (cherry picked from commit 25f03a046b65b1f3db61bf8d23b5611fea3f33fb) (cherry picked from commit 746799602f194b1fc6f6b7c16cc860a23578ce95) --- .../apache/bookkeeper/bookie/InterleavedLedgerStorage.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java index 4e2b6d54b97..d44bd06cc63 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java @@ -38,7 +38,7 @@ import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import io.netty.buffer.ByteBuf; import io.netty.buffer.ByteBufAllocator; - +import io.netty.util.ReferenceCountUtil; import java.io.File; import java.io.IOException; import java.util.ArrayList; @@ -345,7 +345,7 @@ public long getLastAddConfirmed(long ledgerId) throws IOException { lac = bb.readLong(); lac = ledgerCache.updateLastAddConfirmed(ledgerId, lac); } finally { - bb.release(); + ReferenceCountUtil.safeRelease(bb); } } }