This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Change API to return LogicalPlan instead of DataFrame #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nseekhao
reviewed
Dec 7, 2022
| left.join(right, join_type, &left_cols, &right_cols, None) | ||
| let left_cols: Vec<Column> = pairs.iter().map(|(l, _)| l.clone()).collect(); | ||
| let right_cols: Vec<Column> = pairs.iter().map(|(_, r)| r.clone()).collect(); | ||
| left.join(&right, join_type, (left_cols, right_cols), None)? |
There was a problem hiding this comment.
Is the last parameter (filter) that's set to None the same field semantically as Substrait JoinRel's post_join_filter?
If not, please ignore the comment.
If so, should we check if the JoinRel has post_join_filter? And if so, parse it?
There was a problem hiding this comment.
Yes, I think those probably are the same concept. It would be good to implement this in a separate PR.
waynexia
approved these changes
Dec 8, 2022
Yes, I agree with that. |
This was referenced Jan 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @nseekhao, given that
to_substrait_rel()takesLogicalPlanand returns SubstraitRel, it would be better iffrom_subtrait_rel()takes SubstraitReland returnsLogicalPlanrather thanDataFrame.