You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My logic was, if we have a function... for example... named convertPathToString, it should return a string as the output. If we pass a string initially, it should just return the same thing.
I ran into an edge case with https://github.com/jrit/web-resource-inliner - specifically here https://github.com/jrit/web-resource-inliner/blob/6ca0b528b6e7020c9782bc7d8ccbc5ea83818ae0/src/util.js#L184 where the
src
passed was actually a data URI component in itself. I will be submitting a PR toweb-resource-inliner
that sniffs if it's a data URI or not in that block of code, and if so, return the callback early - however I think that perhaps it should be built into this package?My logic was, if we have a function... for example... named convertPathToString, it should return a string as the output. If we pass a string initially, it should just return the same thing.
Could use
validator
'sisDataURI
function here https://github.com/chriso/validator.js/blob/3443132beccddf06c3f0a5e88c1dd2ee6513b612/src/lib/isDataURI.js or importvalidator
and usevalidator.isDataURI
.The text was updated successfully, but these errors were encountered: