Skip to content

Commit 16fb6a9

Browse files
committed
fix: iframe url parsing error management
1 parent 47c21a5 commit 16fb6a9

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

server/utils/page.js

+7-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,13 @@ async function openInPage(page, target, lang, timezone, cookies, viewport, anima
102102

103103
for (const frame of page.frames()) {
104104
const frameUrl = frame.url()
105-
const sameHost = new URL(frameUrl).host === captureHost
105+
if (!frameUrl) continue
106+
let sameHost = false
107+
try {
108+
sameHost = new URL(frameUrl).host === captureHost
109+
} catch (err) {
110+
throw createError(400, 'IFrame with invalid URL :' + frameUrl)
111+
}
106112
if (!sameHost && config.onlySameHost) {
107113
debug(`${frameUrl} from iframe in ${target} is NOT on same host as capture service (${captureHost}), reject`)
108114
throw createError(400, 'IFrame did not have same host :' + new URL(frameUrl).host)

0 commit comments

Comments
 (0)