Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrossFilter worker widget is broken and untested #6303

Closed
crusaderky opened this issue May 8, 2022 · 3 comments · Fixed by #6484
Closed

CrossFilter worker widget is broken and untested #6303

crusaderky opened this issue May 8, 2022 · 3 comments · Fixed by #6484
Assignees

Comments

@crusaderky
Copy link
Collaborator

Dask dashboard -> info -> open any worker -> CrossFilter
Start any computation

Nothing shows up on the widget. On the worker log you can read:

2022-05-08 23:16:33,220 - bokeh.util.tornado - ERROR - Error thrown from periodic callback:
2022-05-08 23:16:33,221 - bokeh.util.tornado - ERROR - Traceback (most recent call last):
  File "/home/crusaderky/miniconda3/envs/distributed39/lib/python3.9/site-packages/distributed/utils.py", line 765, in wrapper
    return func(*args, **kwargs)
  File "/home/crusaderky/miniconda3/envs/distributed39/lib/python3.9/site-packages/distributed/dashboard/components/worker.py", line 360, in update
    d = self.process_msg(msg)
  File "/home/crusaderky/miniconda3/envs/distributed39/lib/python3.9/site-packages/distributed/dashboard/components/worker.py", line 413, in process_msg
    typ = self.worker.types.get(status_key, object).__name__
AttributeError: 'Worker' object has no attribute 'types'

test_worker_bokeh.py::test_basic is supposed to test it, but due to subtle timings reasons it never invokes the update() method.

@quasiben
Copy link
Member

I'm not sure I've ever used the crossfilter. Have you found it useful ?

@crusaderky
Copy link
Collaborator Author

I personally didn't know it existed. I stumbled on it by accident.

@crusaderky
Copy link
Collaborator Author

After conversation with @mrocklin, we agreed to remove the widget completely, at least for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants