-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spill to constrained disk space #5364
Closed
Labels
enhancement
Improve existing functionality or make things work better
Comments
cc @madsbk who has thought a lot about spilling |
This comment has been minimized.
This comment has been minimized.
I don't see a benefit in letting the user alter the spill-to-disk limit after the worker has started? |
Sorry, I meant to put that comment on #5367. Moving to there. |
3 tasks
Merged
This was referenced Feb 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Use case
This has been raised offline by a power user.
Their workers have limited disk space - frequently less than the amount of RAM. At the moment, the user has completely disabled spilling as the spill file will occupy all available space and when that happens OSErrors will start being raised and data will be lost.
Proposed behaviour
Proposed design
zict.File.__setitem__
.sizeof()
of the key to be spilled to the current size of the spill files on disk. If the maximum size would be exceeded, log a warning and don't spill. If memory pressure keeps building up, this will in turn cause the worker to eventually reach the pause threshold.The text was updated successfully, but these errors were encountered: