This repository has been archived by the owner on Jan 4, 2022. It is now read-only.
fix: height check was missing in feature flag data trigger #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
reviewed
Apr 22, 2021
lib/dataTrigger/featureFlagsDataTriggers/createFeatureFlagDataTrigger.js
Outdated
Show resolved
Hide resolved
…s-dpp into fix/feature-flags-data-trigger
shumkov
reviewed
Apr 22, 2021
| expect(result).to.be.an.instanceOf(DataTriggerExecutionResult); | ||
| expect(result.isOk()).to.be.true(); | ||
|
|
||
| // const [error] = result.getErrors(); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
To be sure feature flag is not activated "in the past", additional check has been added
What was done?
createFeatureFlagDataTriggerHow Has This Been Tested?
Unit tests
Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only