Skip to content
This repository has been archived by the owner on Jan 4, 2022. It is now read-only.

feat: use verifyInstantLock instead of fetchSMLStore #294

Merged
merged 2 commits into from
Feb 16, 2021
Merged

feat: use verifyInstantLock instead of fetchSMLStore #294

merged 2 commits into from
Feb 16, 2021

Conversation

jawid-h
Copy link
Contributor

@jawid-h jawid-h commented Feb 16, 2021

Issue being fixed or feature implemented

Using verifyInstantLock method now to move things to the Drive's side

What was done?

  • Updated State Repository interface
  • Updated validateInstantAssetLockProofStructure method

How Has This Been Tested?

Unit tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h added this to the v0.19 milestone Feb 16, 2021
@jawid-h jawid-h requested a review from shumkov February 16, 2021 09:47
shumkov
shumkov reviewed Feb 16, 2021
View reviewed changes
...ty/stateTransitions/assetLock/proof/instant/validateInstantAssetLockProofStructureFactory.js Outdated
@@ -54,9 +54,7 @@ function validateInstantAssetLockProofStructureFactory(
}

if (!skipAssetLockProofSignatureVerification) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove skipAssetLockProofSignatureVerification. We don't need it anymore since we can just do a fallback inside verifyInstantLock if needed.

@jawid-h jawid-h requested a review from shumkov February 16, 2021 10:12
shumkov
shumkov approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit e3e53a5 into v0.19-dev Feb 16, 2021
@shumkov shumkov deleted the feat/verify-sr-method branch February 16, 2021 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.19
Development

Successfully merging this pull request may close these issues.
2 participants
@jawid-h @shumkov