Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

feat!: implement DPNS methods #92

Merged
merged 14 commits into from
Jul 1, 2020
Merged

feat!: implement DPNS methods #92

merged 14 commits into from
Jul 1, 2020

Conversation

jawid-h
Copy link
Contributor

@jawid-h jawid-h commented Jun 19, 2020 •
edited
Loading

Issue being fixed or feature implemented

Trying to move DPNS methods from client.

What was done?

  • Implemented resolve, resolveByRecord, search methods
  • Updated register method
  • Removed get method

How Has This Been Tested?

Unit tests.

Breaking Changes

  • platform.names.get method has been removed

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

shumkov
shumkov approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@shumkov shumkov added this to the v0.14 milestone Jul 1, 2020
@shumkov shumkov merged commit 565f685 into v0.14-dev Jul 1, 2020
@shumkov shumkov deleted the feat/dpns-methods branch July 1, 2020 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

@Alex-Werner Alex-Werner Awaiting requested review from Alex-Werner

@antouhou antouhou Awaiting requested review from antouhou

@shuplenkov shuplenkov Awaiting requested review from shuplenkov

Assignees
No one assigned
Labels
None yet
Milestone
v0.14
Development

Successfully merging this pull request may close these issues.
2 participants
@jawid-h @shumkov