Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

feat: add driveProtocolVersion option #249

Merged
merged 17 commits into from
Aug 24, 2021
Merged

Conversation

jawid-h
Copy link
Contributor

@jawid-h jawid-h commented Aug 11, 2021

Issue being fixed or feature implemented

Add an ability to pass protocol version to DPP

What was done?

  • added driveProtocolVersion client option
  • added mapping between network and version
  • pass protocol version to DPP

How Has This Been Tested?

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h added this to the v0.21.0 milestone Aug 11, 2021
src/SDK/Client/Client.ts Outdated Show resolved Hide resolved
@jawid-h jawid-h requested a review from shumkov August 12, 2021 11:07
shumkov
shumkov previously approved these changes Aug 12, 2021
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shuplenkov shuplenkov merged commit 9f1ce1d into v0.21-dev Aug 24, 2021
@shuplenkov shuplenkov deleted the feat/driveProtocolVersion branch August 24, 2021 09:22
@shuplenkov shuplenkov restored the feat/driveProtocolVersion branch August 24, 2021 09:29
antouhou pushed a commit that referenced this pull request Oct 25, 2021
Co-authored-by: Konstantin Shuplenkov <[email protected]>
antouhou pushed a commit that referenced this pull request Oct 25, 2021
Co-authored-by: Konstantin Shuplenkov <[email protected]>
antouhou pushed a commit that referenced this pull request Oct 26, 2021
Co-authored-by: Konstantin Shuplenkov <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants