Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

fix: ensure name search uses lowercase label #183

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

thephez
Copy link
Contributor

@thephez thephez commented Jan 28, 2021

Issue being fixed or feature implemented

Fixes #182. Perhaps should be backported to v17 also.

What was done?

Created a normalized version of the labelPrefix to use in the query so mixed-case label prefix arguments don't mysteriously fail.

How Has This Been Tested?

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@thephez thephez added this to the v0.18 milestone Jan 28, 2021
@thephez thephez requested review from jawid-h and antouhou January 28, 2021 18:43
@thephez thephez requested a review from Alex-Werner February 15, 2021 15:23
Copy link
Collaborator

@Alex-Werner Alex-Werner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)
UtACK.

@thephez thephez merged commit 144d641 into v0.18-dev Feb 16, 2021
@thephez thephez deleted the fix/name-search-prefix-case branch February 16, 2021 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Name search case sensitivity inconsistency
2 participants